#Tux guitar drums code#
set all stems for all beats to none and draw them in separately) or the code would have to change to allow multiple stems per beat. Either the code would have to "fake" the stems somehow (e.g. For example, from what I can see, the stem direction is set per beat (or rather beat group), i.e. However, this could potentially be difficult to program and may require more modification to how TuxGuitar treats note stems.
The advantages of the first approach would be that drums would always look presentable and perfect, and without special effort from the user to do so. Create a plugin or something that splits the two drum types in a single voice into two voices for better presentability upon user demand.Hardcode note stems for each drum type to point a certain direction (and group in a certain way) or have some other method of overriding the regular stem direction behaviour.To address it, there are two solutions I can think of off of the top of my head: However, I can see why you would see this as an issue with the patch. I intended for it to be up to the user to decide if they wanted to write the drums in separate voices and have a more presentable track or have the convenience of writing it in a single voice. For an example of what I mean, see this image:Īlso, see my attached image of what it would look like in TuxGuitar with the "feet" drums in Voice 2 and the "hands" drums in Voice 1. I would probably suggest removing the rectangle if any.Īs for the note stems (red circles), I intended for the drums and cymbals to be written in separate voices, which would lead to note stem separation. 1 AttachmentsĪs for the clef (green circles), the two small bars appears to be the more common notation, while the rectangle was a holdover from Simon's patch. + over closed hi-hat only occurs on the first closed hi-hat rather than every one of themĪs such, I would definitely consider this an improvement over TuxGuitar's current handling of drum notation and so would urge Julian to include this in the trunk. Size, shape, and positioning of noteheads has been improved Includes more drums and percussion mapped - I mapped everything that I could find a consensus for, which includes all six toms, both crash cymbals, the splash cymbal, china cymbal, both rides and the ride bell, tambourine, cowbell, stick clicks, wood blocks, triangles, both bass drums, hi-hats, etc.
Includes more modifiers, such as a circle around the notehead (for use with the china cymbal, cross stick, etc.) Includes more noteheads, such as a slanted diamond, a triangle, and an "effect cymbal" cross that looks somewhat different Works with the current codebase (I made it part of tuxguitar-lib)
#Tux guitar drums Patch#
This is an updated version of patch #11 () against the latest commit in the trunk.Ĭompared with the original patch, mine has the following improvements: